[PATCH] D75893: [OpenMP] Add !range metadata to loads from omp.(ub/lb)

[Kaushik Kulkarni via Phabricator via llvm-commits]

kaushikcfd added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:250
+        // Support a simple, but widely occurring case.
+        return false;
+
----------------
jdoerfert wrote:
> Style: I would move the comment before the `if` or add braces.
> 
> I'm curious, is this a widely occurring case? Do you know when it occurs in practice?
> I'm curious, is this a widely occurring case? Do you know when it occurs in practice?
I'm sorry, the comment is a bit misleading. I mean't that -- we support adding ranges to a simple but widely occurring case. In my experience, any pragmas that are translated through clang should have OMPLBVal/OMPUBVal as allocas.  Will rephrase it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75893/new/

https://reviews.llvm.org/D75893