[PATCH] D76129: Fix possible assertion when using PBQP with debug info

[Danila Malyutin via Phabricator via llvm-commits]

danilaml added inline comments.


================
Comment at: llvm/test/CodeGen/Generic/csw-debug-assert.ll:2
+; REQUIRES: asserts
+; RUN: llc -O1 -regalloc=pbqp %s -o %t.o
+
----------------
aprantl wrote:
> Please add a comment explaining what is being tested here
> 
> Please add something that explicitly CHECKs the results? Otherwise this test will succeed even if someone symlinks /bin/true to llc :-)
Done.

>From what it seems, the majority of the lit tests are vulnerable to /bin/true trick ;P


================
Comment at: llvm/test/CodeGen/Generic/csw-debug-assert.ll:54
+
+attributes #0 = { nounwind uwtable optnone noinline "correctly-rounded-divide-sqrt-fp-math"="false" "denormal-fp-math"="ieee,ieee" "denormal-fp-math-f32"="ieee,ieee" "disable-tail-calls"="false" "frame-pointer"="none" "less-precise-fpmad"="false" "min-legal-vector-width"="0" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+cx8,+fxsr,+mmx,+sse,+sse2,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" }
+attributes #1 = { nounwind readnone speculatable willreturn }
----------------
aprantl wrote:
> Please delete all nonnecessary attributes, it makes the tests hard to maintain
Done. It's a bit hard to know what's necessary or not when ll is generated from simple C code and not hand-crafted (and you can't just remove all metadata).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76129/new/

https://reviews.llvm.org/D76129