[PATCH] D70720: [llvm-objdump] Display locations of variables alongside disassembly
Eric Christopher via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 13 09:06:50 PDT 2020
echristo accepted this revision.
echristo added a comment.
Couple of random comments, but feel free to fix and commit. I think anything else can be handled post-review.
Thanks!
-eric
================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFExpression.cpp:358
+ const DWARFExpression::iterator E,
+ const MCRegisterInfo *MRI) {
+ SmallVector<PrintedExpr, 4> Stack;
----------------
You assume MRI isn't null so probably just make it a reference.
================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFExpression.cpp:408
+
+bool DWARFExpression::printCompact(raw_ostream &OS, const MCRegisterInfo *MRI) {
+ return printCompactDWARFExpr(OS, begin(), end(), MRI);
----------------
Since MRI is going to be a reference downstream probably want to make it a reference here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70720/new/
https://reviews.llvm.org/D70720
More information about the llvm-commits
mailing list