[PATCH] D76136: [MLIR] Add support for explicitly signed / unsigned integer constants
Stephen Neuendorffer via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 13 09:06:49 PDT 2020
stephenneuendorffer added inline comments.
================
Comment at: mlir/test/IR/parser.mlir:501
+ // CHECK: %{{.*}} = constant 42 : ui32
+ %ux = constant 42 : ui32
----------------
My understanding of the design is that i32 is signless, ui32 is unsigned, and si32 is signed... It seems like you're not testing the explicitly signed case?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76136/new/
https://reviews.llvm.org/D76136
More information about the llvm-commits
mailing list