[PATCH] D76124: [TTI] Remove getOperationCost

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 13 09:06:47 PDT 2020


reames requested changes to this revision.
reames added a comment.
This revision now requires changes to proceed.

You're mixing a bit much in this patch for it to be easily reviewable.  I see a couple of small NFCs which should be pulled out landed, and then the patch rebased.  1) Pulling out static_cast in the getIntrinsicCost and 2) conversion of if chain to switch.



================
Comment at: llvm/include/llvm/CodeGen/BasicTTIImpl.h:712
-      // Bitcast between types that are legalized to the same type are free.
-      if (Opcode == Instruction::BitCast || Opcode == Instruction::Trunc)
         return 0;
----------------
You appear to have dropped the bitcast equal size case.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76124/new/

https://reviews.llvm.org/D76124





More information about the llvm-commits mailing list