[PATCH] D76116: [Verifier] Remove invalid verifier check

[Philip Reames via Phabricator via llvm-commits]

reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: dantrushin.

LGTM

Also, you should add an instcombine which converts a UB length into an unreachable idiom.  That would help simplify your example you shared privately.  (Context: Switch case leading to dead code contains this construct.)



================
Comment at: llvm/test/Verifier/element-wise-atomic-memory-intrinsics.ll:12
 
-  ; CHECK: constant length must be a multiple of the element size in the element-wise atomic memory intrinsic
+  ; CHECK-NOT: constant length must be a multiple of the element size in the element-wise atomic memory intrinsic
   call void @llvm.memcpy.element.unordered.atomic.p0i8.p0i8.i32(i8* align 4 %P, i8* align 4 %Q, i32 7, i32 4)
----------------
Please remove the check line, being overly specific to a message which no longer exists doesn't add any value.


================
Comment at: llvm/test/Verifier/element-wise-atomic-memory-intrinsics.ll:39
 
-  ; CHECK: constant length must be a multiple of the element size in the element-wise atomic memory intrinsic
+  ; CHECK-NOT: constant length must be a multiple of the element size in the element-wise atomic memory intrinsic
   call void @llvm.memmove.element.unordered.atomic.p0i8.p0i8.i32(i8* align 4 %P, i8* align 4 %Q, i32 7, i32 4)
----------------
Same


================
Comment at: llvm/test/Verifier/element-wise-atomic-memory-intrinsics.ll:66
 
-  ; CHECK: constant length must be a multiple of the element size in the element-wise atomic memory intrinsic
+  ; CHECK-NOT: constant length must be a multiple of the element size in the element-wise atomic memory intrinsic
   call void @llvm.memset.element.unordered.atomic.p0i8.i32(i8* align 4 %P, i8 %V, i32 7, i32 4)
----------------
Same


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76116/new/

https://reviews.llvm.org/D76116