[PATCH] D73086: [WIP][DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump.

[Sourabh Singh Tomar via Phabricator via llvm-commits]

SouraVX marked 2 inline comments as done.
SouraVX added inline comments.


================
Comment at: llvm/test/DebugInfo/X86/debug-macro-macinfo.s:8
+# CHECK-NEXT: DW_MACRO_start_file - lineno: 0 filenum: 0
+# CHECK-NEXT:   DW_MACRO_define_strp - lineno: 1 macro: DWARF_VERSION 5
+# CHECK-NEXT: DW_MACRO_end_file
----------------
jhenderson wrote:
> SouraVX wrote:
> > jhenderson wrote:
> > > Why is this indented?
> > emission of `DW_FORM_define_strp` form is getting checked here. Is this what you're asking ?
> I was just confused by the `DW_MACRO_define_strp` causing an extra two spaces of indentation, that's all. It looks slightly broken when I read it with little prior knowledge of debug_macro sections.
The spacing/indentation is part of dumping here, reflecting that this macro is defined under `DW_MACRO_start_file` file.


================
Comment at: llvm/test/DebugInfo/X86/debug-macro-v5.s:7
+
+# CHECK:.debug_macro contents:
+# CHECK-NEXT:0x00000000:
----------------
jhenderson wrote:
> `#      CHECK:.debug_macro contents:`
> 
> same below for the other `CHECK:` line.
Is spacing the you're concerned about here ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73086/new/

https://reviews.llvm.org/D73086