[PATCH] D73832: Ignore/Drop droppable uses for code-sinking in InstCombine

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/Local.cpp:416
+    if ((II->getIntrinsicID() == Intrinsic::assume &&
+         isAssumeWithEmptyBundle(*II)) ||
         II->getIntrinsicID() == Intrinsic::experimental_guard) {
----------------
Can you split the `isAssumeWithEmptyBundle` changes. They look good to me and can be commited, assuming you can add a simple test case showing that instcombine/instsimplify/... will remove certain `assume(true)` but not all.

For the Instcombine sutff I would probably prefer another opinion (@lebedev.ri @spatel @nikic)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73832/new/

https://reviews.llvm.org/D73832