[PATCH] D75828: [AssumeBundles] filter usefull attriutes to preserve

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/lib/IR/KnowledgeRetention.cpp:109
+  }
+}
+
----------------
Tyker wrote:
> jdoerfert wrote:
> > Are we sure we want to keep a positive list of useful ones? (Instead of a negative list of not-useful ones?)
> i looked at all attributes we support and most of them aren't useful. so i think the list is shorter this way and will need less updating.
> 
> but perhaps a negative pattern has a better default.
Let's keep it for now, but at the latest once we have assume ranges it will probably be easier to keep them and opt-out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75828/new/

https://reviews.llvm.org/D75828