[PATCH] D76117: NFC: modernize / clean up some loop transform utils, affine analysis utils

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 13 00:08:11 PDT 2020


rriddle accepted this revision.
rriddle added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/include/mlir/Analysis/AffineStructures.h:317
 
-  void removeId(IdKind idKind, unsigned pos);
+  // Removes the specified identifier from the system.
   void removeId(unsigned pos);
----------------
Please use /// for top level comments.


================
Comment at: mlir/lib/Analysis/AffineStructures.cpp:1204
 
-// Gather lower and upper bounds for the pos^th identifier.
+// Gather all lower and upper bounds of the identifier at `pos`.
 static void getLowerAndUpperBoundIndices(const FlatAffineConstraints &cst,
----------------
Same here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76117/new/

https://reviews.llvm.org/D76117





More information about the llvm-commits mailing list