[PATCH] D69930: [OpenMP] Introduce the OpenMPOpt transformation pass

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

In D69930#1910922 <https://reviews.llvm.org/D69930#1910922>, @xiaoqing_wu wrote:

> In D69930#1901384 <https://reviews.llvm.org/D69930#1901384>, @jdoerfert wrote:
>
> > In D69930#1900147 <https://reviews.llvm.org/D69930#1900147>, @xiaoqing_wu wrote:
> >
> > > This line needs to be guarded with #if !defined(NDEBUG) to prevent warning-as-error failures in release build.
> > >
> > >   static constexpr auto TAG = "[" DEBUG_TYPE "]";
> > >   
> > >
> > > The change made in https://reviews.llvm.org/rGa50c0b0df733423f9f6f92bb4e0be26f73326ae3 is not sufficient to prevent release build issue. Could you fix this? Thanks!
> >
> >
> > I don't understand why this is not sufficient. Could you explain that please? (I usually test with release+asserts
> >
> > > ! In D69930#1901384 <https://reviews.llvm.org/D69930#1901384>, @jdoerfert wrote:
> > > 
> > >> ! In D69930#1900147 <https://reviews.llvm.org/D69930#1900147>, @xiaoqing_wu wrote:
> > > 
> > > This line needs to be guarded with #if !defined(NDEBUG) to prevent warning-as-error failures in release build.
> > > 
> > >   static constexpr auto TAG = "[" DEBUG_TYPE "]";
> > >    
> > > 
> > > The change made in https://reviews.llvm.org/rGa50c0b0df733423f9f6f92bb4e0be26f73326ae3 is not sufficient to prevent release build issue. Could you fix this? Thanks!
> >
> > I don't understand why this is not sufficient. Could you explain that please? (I usually test with release+asserts)
>
>
> TAG is only used when NDEBUG is not defined. It's not used when NDEBUG is not defined and LLVM_ENABLE_DUMP is enabled. To reproduce this, run cmake with these options: -DLLVM_ENABLE_DUMP=On -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=Off.


Sorry for the wait, I got side-tracked bad. Should be fixed by D75970 <https://reviews.llvm.org/D75970>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69930/new/

https://reviews.llvm.org/D69930