[PATCH] D73677: MSVC Buggy version detection: turn pre-processor error into CMake configuration time check

YuPan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 12 21:54:10 PDT 2020


binsys added a comment.

ref: https://docs.microsoft.com/zh-cn/visualstudio/releases/2019/release-notes#16.4.6

ms fixed this bug without bump cl minor version.

new version info:

  _MSC_VER=1924
  _MSC_FULL_VER=192428319

cl version is [19.24.28319]

so we need use

  _MSC_FULL_VER>=192428319 

and compare CMAKE_CXX_COMPILER_VERSION with 19.24.28319


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73677/new/

https://reviews.llvm.org/D73677





More information about the llvm-commits mailing list