[PATCH] D75300: Support prefix padding for alignment purposes (Relaxable instructions only)
Kan Shengchen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 12 19:47:21 PDT 2020
skan added inline comments.
================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp:794-797
+ if (!isFullyRelaxed(RF))
+ for (auto &F : RF.getFixups())
+ if (getFixupKindInfo(F.getKind()).Flags & MCFixupKindInfo::FKF_IsPCRel)
+ return false;
----------------
I'm not sure only checking `FKF_IsPCRel` here is safe enough, since the logic in `X86AsmBackend::applyFixup` also checks whether the value can fit in the fixup field when kind of fixup is not `FKF_IsPCRel`. Can we `return false` directly if `!isFullyRelaxed(RF)`?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75300/new/
https://reviews.llvm.org/D75300
More information about the llvm-commits
mailing list