[PATCH] D76067: [llvm-dwp] Refactor handling of section identifiers. NFCI.

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 12 16:51:16 PDT 2020


dblaikie added a comment.

I don't /mind/ this refactor (though the SectionKindToIndex function should use DW_SECT_INFO rather than the magic number 1) - but I'm not sure it's needed/especially useful given my position (which aligns with @labath's) on the original review D75929 <https://reviews.llvm.org/D75929>. So let's shelve this while we continue the design discussion there & see how it shakes out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76067/new/

https://reviews.llvm.org/D76067





More information about the llvm-commits mailing list