[PATCH] D76085: [DWARFLinker][dsymutil][NFC] add section index into address range.

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

My only rough thought here (as I'm not especially versed in the DWARFLinker code) is that this feature (doing debug info redundancy elimination during ld -r) seems more like a stretch/later goal & I'd have thought it'd be likely/better to implement this for non"-r" linking first, since that's close(r) to the llvm-dsymutil functionality already in DWARFLinker, then in subsequent patches generalize this (in the way you're proposing) to handle the "-r" sort of case, which is probably (likely/actually) more complicated (or at least more new code, since it's not something that DWARFLuinker has had to support until this point), keeping track of addresses, etc.

Could changes like this be tested (possibly unit tested) in some way? I guess DWARFLinker funcitonality's been tested in llvm-dsymutil up until this point - but this is the first major/new functionality DWARFLinker will support that llvm-dsymutil does not support, so some in-tree testing story will need to be created.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76085/new/

https://reviews.llvm.org/D76085