[PATCH] D75879: [lld][WIP]Enabling loading LLVM pass plugins

[Eli Friedman via Phabricator via llvm-commits]

efriedma marked an inline comment as done.
efriedma added inline comments.


================
Comment at: lld/tools/lld/CMakeLists.txt:11
   )
+export_executable_symbols(lld)
 
----------------
MaskRay wrote:
> Does this CMake function enable -rdynamic (the same as -Wl,--export-dynamic)? It can make the executable much larger because all defined symbols in .symtab will end up in .dynsym and consume a lot of .dynstr space...
Yes.  We have to expose all the LLVM symbols so that the plugin can use them (the plugin has to be using the same LLVM as lld itself).  We do the same thing in clang.

I guess we could add a CMake option to disable this, if you want a minimal config that doesn't support pass plugins.  Not sure how likely it is anyone would use such an option.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75879/new/

https://reviews.llvm.org/D75879