[PATCH] D75892: [InstSimplify][SVE] Fix SimplifyGEPInst for scalable vector.
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 12 15:45:25 PDT 2020
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:4085
+ bool IsScalableVec =
+ SrcTy->isVectorTy() ? SrcTy->getVectorIsScalable() : false;
+
----------------
We should probably consider adding an API to Type to check whether the size of a type is a compile-time constant, so we don't repeat `SrcTy->isVectorTy() ? SrcTy->getVectorIsScalable() : false` all over the place. I guess that doesn't have to happen here, though.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75892/new/
https://reviews.llvm.org/D75892
More information about the llvm-commits
mailing list