[PATCH] D75956: [mlir] [VectorOps] Progressively lower vector.outerproduct to LLVM

Thu Mar 12 13:34:28 PDT 2020

aartbik added inline comments.

================
Comment at: mlir/include/mlir/Dialect/VectorOps/VectorOps.h:65
+/// and broadcast ops.
+void populateVectorChangesLoweringPatterns(OwningRewritePatternList &patterns,
+                                           MLIRContext *context);
----------------
nicolasvasilache wrote:
> I don't think `VectorChangesLoweringPatterns` is appropriate, this is really all the patterns that come together to lower VectorContract.
> I would either keep the original name of call it `polulateVectorContractAndDependentLoweringPatterns`.
> In the future I expect we'll have more "key" vector ops that will be lowered through other patterns and "Change" wouldn't work either.
Fair enough. I will just keep the name and flag as it was. A slight misnomer, but it will make merging and updating subsequent CLs a lot easier!

Thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75956/new/

https://reviews.llvm.org/D75956