[PATCH] D75956: [mlir] [VectorOps] Progressively lower vector.outerproduct to LLVM

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache accepted this revision.
nicolasvasilache added a comment.

LGTM except the "Changes" name.
I'll defer to you to use either of my 2 proposals or find something better, in light of we will have multiple such "Changes" cases in the future.



================
Comment at: mlir/include/mlir/Dialect/VectorOps/VectorOps.h:65
+/// and broadcast ops.
+void populateVectorChangesLoweringPatterns(OwningRewritePatternList &patterns,
+                                           MLIRContext *context);
----------------
I don't think `VectorChangesLoweringPatterns` is appropriate, this is really all the patterns that come together to lower VectorContract.
I would either keep the original name of call it `polulateVectorContractAndDependentLoweringPatterns`.
In the future I expect we'll have more "key" vector ops that will be lowered through other patterns and "Change" wouldn't work either.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75956/new/

https://reviews.llvm.org/D75956