[PATCH] D76019: [mlir][NFC] Move the definition of AffineApplyOp to ODS

[Uday Bondhugula via Phabricator via llvm-commits]

bondhugula accepted this revision.
bondhugula added inline comments.


================
Comment at: mlir/include/mlir/Dialect/AffineOps/AffineOps.td:49
+    arguments to affine.apply must be equal to the respective number of
+    dimensional and symbolic inputs to the affine mapping; the affine.apply
+    operation always returns one value. The input operands and result must all
----------------
-> the affine mapping has to be one-dimensional, and so the affine.apply operation always returns one value. 

?


================
Comment at: mlir/include/mlir/Dialect/AffineOps/AffineOps.td:67
+
+  // TODO: The auto-generated builders should check to see if the return type
+  // has a constant builder.
----------------
? This doesn't appear clear to me. 


================
Comment at: mlir/lib/Dialect/AffineOps/AffineOps.cpp:247
+static void print(OpAsmPrinter &p, AffineApplyOp op) {
+  p << "affine.apply " << op.mapAttr();
+  printDimAndSymbolList(op.operand_begin(), op.operand_end(),
----------------
`AffineApplyOp::getOperationName()` while at this. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76019/new/

https://reviews.llvm.org/D76019