[PATCH] D75342: [obj2yaml] - Teach tool to dump program headers.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/Object/obj2yaml.test:670
+# ELF-AVR-NEXT:     - Section: .text
+# ELF-AVR-NEXT:     - Section: .data
+# ELF-AVR-NEXT:    Align: 0x0000000000000002
----------------
grimar wrote:
> `.data` section size == 0, I wonder if it is OK we dump it?
> 
> Can we ignore empty sections at the end of segment? I.e do what D74755 removes:
> 
> ```
> // If a section is empty it should be treated like it has a size of 1. This is
> // to clarify the case when an empty section lies on a boundary between two
> // segments and ensures that the section "belongs" to the second segment and
> // not the first.
> uint64_t SecSize = Sec.Size ? Sec.Size : 1;
> ```
I vote for removing `uint64_t SecSize = Sec.Size ? Sec.Size : 1;`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75342/new/

https://reviews.llvm.org/D75342