[PATCH] D75755: [AArch64][Fix] LdSt optimization generate premature stack-popping

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 12 09:13:16 PDT 2020


efriedma added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp:1814
+      if (MayAccessStack && Offset > 0)
+        continue;
       return MBBI;
----------------
"continue"? Should we really be continuing to search past an instruction which modifies sp?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75755/new/

https://reviews.llvm.org/D75755





More information about the llvm-commits mailing list