[PATCH] D75796: [llvm-objdump][test] Reorganize ELF --syms tests
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 12 08:08:39 PDT 2020
MaskRay added inline comments.
================
Comment at: llvm/test/tools/llvm-objdump/ELF/symbol-table.test:104
+# ELF32:SYMBOL TABLE:
+# ELF32-NEXT:00000000 *UND* 00000000 sym
+
----------------
grimar wrote:
> Perhaps it can be
>
> ```
> # ADDR:SYMBOL TABLE:
> # ADDR-NEXT:[[NULL]] *UND* [[NULL]] sym
>
> > FileCheck -D NULL=00000000 ...
> > FileCheck -D NULL=0000000000000000 ....
>
> ```
>
> (I am not sure we want it. It has its pros and cons)
With --match-full-lines --strict-whitespace, may be fine keeping the original literal form...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75796/new/
https://reviews.llvm.org/D75796
More information about the llvm-commits
mailing list