[PATCH] D76056: [MemFunctions] Add validity check.

[Clement Courbet via Phabricator via llvm-commits]

courbet added a comment.

Thanks, PTAL.



================
Comment at: MicroBenchmarks/MemFunctions/main.cpp:56
+  // First check the validity of the results.
+  if (Pred()(RealMemCmp(p, q, kSize)) != Pred()(memcmp(p, q, kSize))) {
+    std::cerr << "invalid results for Pred=" << Pred::kDisplay
----------------
gchatelet wrote:
> Maybe it's worth instantiating the predicate object and use it as a functor.
> It would help readability.
Actually there is no reason to create an instance. I made the function static.


Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76056/new/

https://reviews.llvm.org/D76056