[PATCH] D75342: [obj2yaml] - Teach tool to dump program headers.

[George Rimar via Phabricator via llvm-commits]

grimar updated this revision to Diff 249900.
grimar marked 5 inline comments as done.
grimar edited the summary of this revision.
grimar added a comment.

- Reimplemented, added test cases.

In D75342#1903392 <https://reviews.llvm.org/D75342#1903392>, @MaskRay wrote:

> @jhenderson listed many good test cases. It requires some work. I've left some notes.


Thank you guys for these suggestions and comments, I used them in the update.

I've added tests for all cases listed except the next two.

>> Segments with gaps in them (file size != size of all sections), where gap is at start/middle/end of segment.
> 
> Type: Filler

I think we might want having a separate test for this. Also it needs more code I think.

>> Segments with memsize > file size.
> 
> Needs non-empty SHT_NOBITS.

I'd like to support SHT_NOBITS case separatelly too for the same reasons.

How does it sound?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75342/new/

https://reviews.llvm.org/D75342

Files:
  llvm/include/llvm/ObjectYAML/ELFYAML.h
  llvm/test/Object/obj2yaml.test
  llvm/test/tools/obj2yaml/program-headers.yaml
  llvm/tools/obj2yaml/elf2yaml.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75342.249900.patch
Type: text/x-patch
Size: 19614 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200312/d3c263d0/attachment.bin>