[PATCH] D75888: [mlir][SideEffects] Mark the CFG only terminator operations as NoSideEffect

[Stephan Herhut via Phabricator via llvm-commits]

herhut accepted this revision.
herhut added a comment.
This revision is now accepted and ready to land.

For the dialects I am involved with this looks reasonable.



================
Comment at: mlir/lib/Transforms/CSE.cpp:127
+  // Don't simplify terminator operations.
+  if (op->isKnownTerminator())
+    return failure();
----------------
This might still simplify terminator operations that we do not identify as those. Is the idea that those still have to remain side-effecting? Or will this be fixed in a future iteration with more detailed modelling?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75888/new/

https://reviews.llvm.org/D75888