[PATCH] D76050: [LoopPeel] Turn incorrect assert into a check

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev marked an inline comment as done.
mkazantsev added inline comments.


================
Comment at: llvm/test/Transforms/LoopUnroll/wrong_assert_in_peeling.ll:77
+bb2:                                              ; preds = %bb12, %bb1
+  %tmp3 = phi i32 [ undef, %bb1 ], [ %tmp4, %bb12 ]
+  %tmp4 = add nsw i32 %tmp3, %tmp
----------------
fhahn wrote:
> are the undef here and in other places required for the test case? Otherwise I think it would be better to replace them with constants/regular values to make the test case more robust. Same for branch on constants.
We have quite a lot tests using undef and afaik there is no problems with their robustness.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76050/new/

https://reviews.llvm.org/D76050