[PATCH] D76050: [LoopPeel] Turn incorrect assert into a check

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 12 03:46:57 PDT 2020


fhahn added inline comments.


================
Comment at: llvm/test/Transforms/LoopUnroll/wrong_assert_in_peeling.ll:77
+bb2:                                              ; preds = %bb12, %bb1
+  %tmp3 = phi i32 [ undef, %bb1 ], [ %tmp4, %bb12 ]
+  %tmp4 = add nsw i32 %tmp3, %tmp
----------------
are the undef here and in other places required for the test case? Otherwise I think it would be better to replace them with constants/regular values to make the test case more robust. Same for branch on constants.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76050/new/

https://reviews.llvm.org/D76050





More information about the llvm-commits mailing list