[PATCH] D75796: [llvm-objdump][test] Reorganize ELF --syms tests

[George Rimar via Phabricator via llvm-commits]

grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.

LGTM with 2 nits, please wait to see if @jhenderson is happy too.



================
Comment at: llvm/test/tools/llvm-objdump/ELF/symbol-table.test:40
+    Index:   SHN_ABS
+
+  - Name:    func
----------------
grimar wrote:
> https://reviews.llvm.org/D75793#inline-690488
nit: I think you can remove empty "Name".


================
Comment at: llvm/test/tools/llvm-objdump/ELF/symbol-table.test:97
+
+## For an ELF32 object, print the address and size fields as 32-bit hexadecimals.
+# RUN: yaml2obj --docnum=2 -D BITS=32 %s -o %t.32
----------------
nit: missing the 64-bit version.



================
Comment at: llvm/test/tools/llvm-objdump/ELF/symbol-table.test:104
+#      ELF32:SYMBOL TABLE:
+# ELF32-NEXT:00000000         *UND*	00000000 sym
+
----------------
Perhaps it can be

```
#      ADDR:SYMBOL TABLE:
# ADDR-NEXT:[[NULL]]         *UND*  [[NULL]] sym

> FileCheck -D NULL=00000000 ...
> FileCheck -D NULL=0000000000000000 ....

```

(I am not sure we want it. It has its pros and cons)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75796/new/

https://reviews.llvm.org/D75796