[PATCH] D76033: [AMDGPU] Simplify nested SI_END_CF

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 11 17:11:28 PDT 2020


rampitec marked an inline comment as done.
rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SILowerControlFlow.cpp:408-410
+MachineBasicBlock::iterator
+SILowerControlFlow::skipIgnoreExecInstsTrivialSucc(
+  MachineBasicBlock &MBB, MachineBasicBlock::iterator It) const {
----------------
arsenm wrote:
> Was this copied directly from SIOptimizeExecMaskingPreRA.cpp? Should this go in a utility function somewhere?
Almost. There are some mechanical and interface changes, but this is essentially the same code.
I do not need it in the utilities as the subsequent patch should remove this code from SIOptimizeExecMaskingPreRA.cpp completely.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76033/new/

https://reviews.llvm.org/D76033





More information about the llvm-commits mailing list