[PATCH] D72194: [MC][ELF] Ensure that mergeable globals with an explicit section are assigned to SHF_MERGE sections with compatible entsizes

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:598
+  if (const auto *F = dyn_cast<Function>(GO)) {
+    const auto &OptionalPrefix = F->getSectionPrefix();
+    if (OptionalPrefix)
----------------
`if (Optional<StringRef> Prefix = F->getSectionPrefix())`


================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:605
+    Name.push_back('.');
+    TM.getNameWithPrefix(Name, GO, Mang, true /*MayAlwaysUsePrivate*/);
+  }
----------------
`/*MayAlwaysUsePrivate=*/true`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72194/new/

https://reviews.llvm.org/D72194