[PATCH] D76036: [mlir][SideEffects] Replace HasNoSideEffect with the memory effect interfaces.

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini accepted this revision.
mehdi_amini added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/lib/Dialect/LoopOps/Transforms/ParallelLoopFusion.cpp:152
+      auto effects = dyn_cast<MemoryEffectOpInterface>(&op);
+      noSideEffects &= (effects && effects.hasNoEffect());
     }
----------------
I see this pattern frequently, could it be a static helper on `MemoryEffectOpInterface`?
```
bool MemoryEffectOpInterface::hasNoEffect(Operation *);
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76036/new/

https://reviews.llvm.org/D76036