[PATCH] D75755: [AArch64][Fix] LdSt optimization generate premature stack-popping

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp:1832
+        }
+        if (PSVa->mayAlias(MFI)){
+          MayAliasFP = true;
----------------
dnsampaio wrote:
> efriedma wrote:
> > I'm not sure what you think this mayAlias check is doing?
> Following a similar code from MachineInstr.mayAlias code, I thought this was just eliminating some trivial cases where the instruction would not access the stack, but now that I see the definition, I'm not so sure.
I still don't know why you're calling PseudoSourceValue::mayAlias.  You don't care whether the access may alias other accesses; you care whether you're accessing the stack.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75755/new/

https://reviews.llvm.org/D75755