[PATCH] D75953: [mlir] Add derived attribute op interface

[Jacques Pienaar via Phabricator via llvm-commits]

jpienaar added inline comments.


================
Comment at: mlir/include/mlir/Interfaces/CMakeLists.txt:13
+mlir_tablegen(DerivedAttributeOpInterface.h.inc -gen-op-interface-decls)
+mlir_tablegen(DerivedAttributeOpInterface.cpp.inc -gen-op-interface-defs)
+add_public_tablegen_target(MLIRDerivedAttributeOpInterfaceIncGen)
----------------
rriddle wrote:
> Looks like you are missing the accompanying .cpp file and the necessary CMake changes, i.e. nothing seems to include `DerivedAttributeOpInterface.cpp.inc`
D'oh, seems I should probably avoid operating heavy machinery today ...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75953/new/

https://reviews.llvm.org/D75953