[PATCH] D75871: [mlir][spirv] NFC: put SPIR-V attributes in separate files

[Lei Zhang via Phabricator via llvm-commits]

antiagainst added a comment.

In D75871#1917734 <https://reviews.llvm.org/D75871#1917734>, @mravishankar wrote:

> The diff has a whole lot of red, I am not sure where the methods were put. Is this an issue with the uploaded Diff?


They are split into two files. If you check the two read parts, they compose the original file. It's showing as red from the new file's perspective.

In D75871#1915414 <https://reviews.llvm.org/D75871#1915414>, @mravishankar wrote:

> I am not sure its a good idea having so many headers. I am OK with having all of them in the same file. In this case specifically, the interface ABI and the target-env, vce attributes are needed for clients who are trying to serialize to SPIR-V binary. It makes sense to have them in one file


Smaller headers offer better organization structure and faster compilation time. For users of target/ABI stuff, it does not affect things given that the new header is included anyway.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75871/new/

https://reviews.llvm.org/D75871