[PATCH] D75965: [mlir] Add a simplifying wrapper for generateCopy and expose it.

[Uday Bondhugula via Phabricator via llvm-commits]

bondhugula added inline comments.


================
Comment at: mlir/test/Transforms/affine-data-copy.mlir:10
 // RUN: mlir-opt %s -split-input-file -test-affine-data-copy='memref-filter=1' | FileCheck %s --check-prefix=FILTER
+// RUN: mlir-opt %s -split-input-file -test-affine-data-copy='from-memref-region=1' | FileCheck %s --check-prefix=MEMREF_REGION
 
----------------
Do you need the '=1'? It could be confusing unless it's '=true'.


================
Comment at: mlir/test/lib/Transforms/TestAffineDataCopy.cpp:86
+    MemRefRegion region(loopNest.getLoc());
+    region.compute(load, 0);
+    generateCopyFromMemRefRegion(region, loopNest, copyOptions, result);
----------------
/*loopDepth = */0


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75965/new/

https://reviews.llvm.org/D75965