[PATCH] D75966: [ELF] Move --print-map(-M)/--cref before checkSections() and openFile()

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

I think Peter's suggestion is whether (1) we should do an automatic -M when the link fails (2) where we should do -M.

We could move -M earlier further, just after `finalizeSections()`, but these steps between `finalizeSections()` and `checkSections` rarely calls `error`.
I am still hesitant making -M an automatic thing. It can get in the way if I am diagnosing a problem with -t -y etc, then we will also need an option to turn off the automatic -M. We have --reproduce, so reproducing a link is really easy. I currently don't think an automatic -M is necessary.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75966/new/

https://reviews.llvm.org/D75966