[PATCH] D75808: [ValueTracking] isKnownNonZero, computeKnownBits for freeze

[Juneyoung Lee via Phabricator via llvm-commits]

aqjune marked an inline comment as done.
aqjune added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:4561
+
+  if (auto BI = dyn_cast<BitCastInst>(V))
+    return isGuaranteedNotToBeUndefOrPoison(BI->getOperand(0), AllowUndef, CtxI,
----------------
reames wrote:
> We've ended up with potentially very deep recursion here.  In general, ValueTracking works with a small fixed depth window.  I think we need to add the same here.  (Should be done as a separate patch.)
> 
> Note: I don't think we can have a cycle in the graph since we only allow constant arguments to phis.
Made a separate patch here: https://reviews.llvm.org/D76010 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75808/new/

https://reviews.llvm.org/D75808