[PATCH] D70720: [llvm-objdump] Display locations of variables alongside disassembly

[Oliver Stannard (Linaro) via Phabricator via llvm-commits]

ostannard marked 2 inline comments as done.
ostannard added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/ARM/debug-vars-wide-chars.s:8
+
+## The han character in the source does not print correctly on windows.
+# UNSUPPORTED: system-windows
----------------
jhenderson wrote:
> Nit: windows -> Windows
> 
> It might be wise to change "han" -> "'喵'" as I don't know what the "han" character is.
I was using "han character" meaning a Chinese, Japanese or Korean character, but it seems like "Chinese character" is a more common term, so I'll switch to that. I'd rather not use the character itself in a comment explaining that it might not render correctly on some systems!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70720/new/

https://reviews.llvm.org/D70720