[PATCH] D62738: [HIP] Support attribute hip_pinned_shadow

Yaxun Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 11 11:19:19 PDT 2020


yaxunl added a comment.

@tra Originally we introduced the `__hip_pinned_shadow__` attribute to support texture type. It ended up as a variable attribute for more generic usage.

However we got usability issue since users have to add this attribute whenever they use texture type. I would like to propose to allow this attribute to both types and variables.

What do you think?

Thanks.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62738/new/

https://reviews.llvm.org/D62738





More information about the llvm-commits mailing list