[PATCH] D75866: [AIX] supporting the visibility attribute for aix assembly

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/MC/MCAsmStreamer.cpp:840
+  EmitEOL();
+  return;
+}
----------------
This `return` is redundant with reaching the end of the function.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1607
+    // If external, declare as a global symbol: .globl _foo
+    if (GV->isDeclaration())
+      OutStreamer->EmitXCOFFSymbolLinkageWithVisibility(GVSym, MCSA_Extern,
----------------
Would it make sense to do
`GV->isDeclaration() ? MCSA_Extern : MCSA_Global`
?


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1615
+  case GlobalValue::InternalLinkage:
+    if (MAI->hasDotLGloblDirective())
+      OutStreamer->EmitSymbolAttribute(GVSym, MCSA_LGlobal);
----------------
For AIX asm, I would like to believe that this is always true.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75866/new/

https://reviews.llvm.org/D75866