[PATCH] D73600: [Matrix] Add remark propagation along the inlined-at chain.

Wed Mar 11 10:46:06 PDT 2020

fhahn marked 2 inline comments as done.
fhahn added a comment.

In D73600#1917094 <https://reviews.llvm.org/D73600#1917094>, @anemet wrote:

> In the description when you say:
>
> > We then generate remarks using the list of instructions for
> >  each subprogram. This allows surfacing the remarks at a level useful to
> >  users.
>
> I would make it explicit that here subprograms is meant to include its own subprograms recursively.  E.g. using the example for the subprogram test this includes load and store inlined functions.
>
> LGTM with these.

Thanks, will do!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73600/new/

https://reviews.llvm.org/D73600