[PATCH] D75131: [XCOFF][AIX] Enable -r option for llvm-objdump

Jason Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 11 10:46:04 PDT 2020


jasonliu marked an inline comment as done.
jasonliu added inline comments.


================
Comment at: llvm/tools/llvm-objdump/XCOFFDump.cpp:22
+                                                SmallVectorImpl<char> &Result) {
+  symbol_iterator SymI = Rel.getSymbol();
+  Expected<StringRef> SymNameOrErr = SymI->getName();
----------------
DiggerLin wrote:
> what happen if the SymI point to symbol_end() ?
> 
We will return error for it. Thanks for point it out. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75131/new/

https://reviews.llvm.org/D75131





More information about the llvm-commits mailing list