[PATCH] D75120: [ValueLattice] Add new state for undef constants.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/include/llvm/Analysis/ValueLattice.h:137
+    if (isa<UndefValue>(C))
+      Res.markUndefined();
+    else
----------------
I'm not sure I understand how getNot(undef) is supposed to work.


================
Comment at: llvm/include/llvm/Analysis/ValueLattice.h:297
       *this = RHS;
-      return !RHS.isUndefined();
+      return !RHS.isUnknown();
     }
----------------
We already checked RHS.isUnknown() earlier?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75120/new/

https://reviews.llvm.org/D75120