[PATCH] D75845: [ValueLattice] Add singlecrfromundef lattice value.

[Eli Friedman via Phabricator via llvm-commits]

efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM, with some updates to the comments.



================
Comment at: llvm/include/llvm/Analysis/ValueLattice.h:31
     /// state in our local meet rules.  In this usage, it's taken to mean
     /// "nothing known yet".
     unknown,
----------------
I think it would make sense to list out the possible state transitions for each state here.


================
Comment at: llvm/include/llvm/Analysis/ValueLattice.h:53
+    /// This Value contains a single element constant range and started out from
+    /// undef. Merging it with other constant ranges results in overdefined,
+    /// unless they match the single element constant range.
----------------
I would prefer to say something like "This Value contains a single element constant range that was merged with an Undef value".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75845/new/

https://reviews.llvm.org/D75845