[PATCH] D76006: [TableGen][GlobalISel] Rework RegisterBankEmitter for easier const correctness

Lewis Revill via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 11 10:13:08 PDT 2020


lewis-revill created this revision.
lewis-revill added reviewers: dsanders, simoncook.
Herald added subscribers: llvm-commits, rovka.
Herald added a project: LLVM.

This patch rewrites the RegisterBankEmitter class to derive RegisterClassHierarchy from CodeGenTarget::getRegBank() rather than constructing our own copy. All are now accessed through a const reference.

This appeared to fix a case of invalidating vectors within RegisterClassHierarchy.getHwModes() - found when testing implementations for another RegisterBankEmitter patch.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D76006

Files:
  llvm/utils/TableGen/CodeGenRegisters.cpp
  llvm/utils/TableGen/CodeGenRegisters.h
  llvm/utils/TableGen/RegisterBankEmitter.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76006.249664.patch
Type: text/x-patch
Size: 5449 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200311/d743e706/attachment.bin>


More information about the llvm-commits mailing list