[PATCH] D69891: [VP,Integer,#1] Vector-predicated integer intrinsics

[Andy Kaylor via Phabricator via llvm-commits]

andrew.w.kaylor added a comment.

I'm satisfied with the functionality, but I'm not sure about the intrinsics having undefined behavior outside the [0, W] range. The way you've implemented it, it seems like the behavior would be predictable. If the evl argument is outside that range, it is ignored. Applying an unsigned value greater than W using the "%mask AND %EVLmask" also has this effect. Why not just make that the defined behavior?



================
Comment at: llvm/lib/IR/IntrinsicInst.cpp:294
+      return false;
+    auto ParMod = ParFunc->getParent();
+    if (!ParMod)
----------------
You can get here in one step with 'this->getModule()'


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69891/new/

https://reviews.llvm.org/D69891