[PATCH] D75859: [CodeGenPrepare] Fold br(freeze(icmp x, const)) to br(icmp(freeze x, const))
Philip Reames via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 11 10:10:10 PDT 2020
reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.
LGTM w/comments applied.
================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:7202
+ if (!Const0 || !Const1) {
+ auto F = new FreezeInst(Const0 ? Op1 : Op0, FI->getName(), II);
+ II->setOperand(Const0 ? 1 : 0, F);
----------------
style: auto *F
================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:7202
+ if (!Const0 || !Const1) {
+ auto F = new FreezeInst(Const0 ? Op1 : Op0, FI->getName(), II);
+ II->setOperand(Const0 ? 1 : 0, F);
----------------
reames wrote:
> style: auto *F
Use takeName instead of getName to avoid additional name mangling.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75859/new/
https://reviews.llvm.org/D75859
More information about the llvm-commits
mailing list