[PATCH] D75994: [GlobalISel] add additional lowering support for G_INSERT

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:4832
 
-    auto Mask = MIRBuilder.buildConstant(IntDstTy, MaskVal);
-    auto MaskedSrc = MIRBuilder.buildAnd(IntDstTy, Src, Mask);
-    auto Or = MIRBuilder.buildOr(IntDstTy, MaskedSrc, ExtInsSrc);
+  if (!InsertTy.isScalar())
+    InsertSrc =
----------------
arsenm wrote:
> Indentation mess. Move the scalar type to a variable, and add braces?
This should probably fail for a non integral address space


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:4832-4837
+  if (!InsertTy.isScalar())
+    InsertSrc =
+        MIRBuilder
+            .buildPtrToInt(LLT::scalar(InsertTy.getSizeInBits()), InsertSrc)
+            .getReg(0);
 
----------------
Indentation mess. Move the scalar type to a variable, and add braces?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75994/new/

https://reviews.llvm.org/D75994