[PATCH] D75866: [AIX] supporting the visibility attribute for aix assembly

David Tenty via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 11 09:37:12 PDT 2020


daltenty added a comment.

Are we forgetting the case of commons? They also have visibility as part of the assembler directive on AIX.



================
Comment at: llvm/lib/MC/MCXCOFFStreamer.cpp:48
+void MCXCOFFStreamer::EmitXCOFFSymbolAttrWithVisibility(
+    MCSymbol *Symbol, MCSymbolAttr Attribute, MCSymbolAttr Visibilitily) {
+  EmitSymbolAttribute(Symbol, Attribute);
----------------
hubert.reinterpretcast wrote:
> Whole file:
> s/Visibilitily/Visibility/g;
> 
Not just this file, spelling issue is pervasive. Also check 'Visibiltiy'


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75866/new/

https://reviews.llvm.org/D75866





More information about the llvm-commits mailing list